bug(medcat-demo-app): CU-869azbdfh Fail without model #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Task linked: CU-869azbdfh Fix demo app |
alhendrickson
approved these changes
Oct 28, 2025
mart-r
deleted the
bug/medcat-demo-app/CU-869azbdfh-fail-without-model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo app would (so far) catch the exception when model load fails and print it (in a very much unuseful way) and still run the app.
There's no reason for the demo app to run without a loaded model.
So this PR makes the service fail (and produce a stack trace) if/when model loading fails.
It also removes a few env variables that weren't used.